Remove sniffs requiring trailing comma #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR removes three sniffs from the
Syde-Extrastandard.What is the current behavior? (You can also link to an open issue here)
Currently, the following three Slevomat sniffs are part of the
Syde-Extrastandard:SlevomatCodingStandard.Functions.RequireTrailingCommaInCallSlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUseSlevomatCodingStandard.Functions.RequireTrailingCommaInDeclarationThese sniffs require a trailing comma in multi-line function calls, closure
usedeclarations, and function declarations, respectively.On PHP 7.4., such a trailing comma is invalid, though, making it harder to use PHP_CodeSniffer across PHP 7.4 and newer.
What is the new behavior (if this is a feature change)?
The above three sniffs have been removed from the
Syde-Extrastandard. This means that trailing are still supported/allowed, but no longer required, which allows writing code that is valid across PHP 7.4+.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Other information: